fix: add timeout on close to flush the I/O operations#52
Open
daiyam wants to merge 1 commit intooverlookmotel:masterfrom
Open
fix: add timeout on close to flush the I/O operations#52daiyam wants to merge 1 commit intooverlookmotel:masterfrom
daiyam wants to merge 1 commit intooverlookmotel:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In the tests, there some
setTimeoutcall to have the reader correctly closed.This PR is moving the
setTimeoutcall inside theclosemethod so it's more consistent.I found this fix while making https://github.com/zokugun/node-yauzl-plus