🔧 Use conan_provider for running conan #1518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ping me when this is ready for review and testing. |
|
You asked me to take a look at libnode not building: It appears as if it isn't building with C++17 or higher. It requires at least C++17 to build, but I believe it should just throw an error if the wrong C++ standard is used. No idea why it isn't throwing that warning. overte/tools/conan-profiles/vs-19-debug Line 10 in 97432d5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically copies the cmake build settings over to a temporary conan profile and invokes
conan install, so no need to run conan manually anymore