Remove Oculus plugins #1975
Draft
Remove Oculus plugins #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove the old Oculus plugins, since they are not in use anymore and only add maintenance burden (in fact, right now they are breaking Windows builds again).
Searching for
oculusin our codebase reveals a lot more Oculus specific logic than I would have anticipated. My favorite so far is the LOD being hard-coded to “high” for Oculus Store builds only.Questions I have run into so far:
scripts/system/controllers/touchControllerConfiguration.jsspecific to the Oculus plugin? The surrounding code suggests a controller configuration UI to me, though I haven't looked that closely yet.