fix: compare resize target against current allocator capacity - #466
Open
jeff3071 wants to merge 1 commit into
Open
fix: compare resize target against current allocator capacity#466jeff3071 wants to merge 1 commit into
jeff3071 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the resize watcher failing to restore an allocator to its initial capacity after shrinking.
mem_size_per_layer_stores the startup capacity and is not updated byresize(). The watcher therefore treated the initial limit as unchanged even when the allocator was currently smaller.Use
num_total_pages_ * page_size_as the current allocator capacity instead.Test
Added a regression test covering: