Skip to content

feat: Add secrets API #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add secrets API #21

wants to merge 2 commits into from

Conversation

inessebz
Copy link
Contributor

@inessebz inessebz commented Feb 4, 2025

No description provided.

phsym
phsym approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@phsym phsym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update version.txt (next to the swagger file) if needed

@inessebz inessebz force-pushed the dev/ibenzekr/EK-1065/secrets branch from c0e103b to 33a0e10 Compare February 5, 2025 08:57
@inessebz inessebz force-pushed the dev/ibenzekr/EK-1065/secrets branch from 33a0e10 to a735875 Compare March 7, 2025 17:47
@inessebz inessebz requested a review from a team as a code owner March 7, 2025 17:47
@inessebz inessebz force-pushed the dev/ibenzekr/EK-1065/secrets branch from a735875 to 73bb8f0 Compare March 12, 2025 13:23
@inessebz inessebz force-pushed the dev/ibenzekr/EK-1065/secrets branch 4 times, most recently from 103e5db to a44a71a Compare March 25, 2025 14:19
@inessebz inessebz force-pushed the dev/ibenzekr/EK-1065/secrets branch from a44a71a to 2a75059 Compare March 26, 2025 10:33
ldesauw
ldesauw reviewed Mar 26, 2025
View reviewed changes
client.go
}

// PostSecretV2 creates a new secret with metadata.
func (client *apiClient) PostSecretV2(ctx context.Context, cas *uint32, body types.PostSecretV2Request) (*types.PostSecretV2Response, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CAS is not useful here since it's only the creation of the secret.
It would be useful for the Put method tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldesauw ldesauw ldesauw approved these changes

@phsym phsym phsym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inessebz @phsym @ldesauw