delete vagrant (#102) #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chaudron Hi, I know you have used ovn-fake-multinode with vagrant in the past. Any objections to this PR? |
|
I have not used this feature for the last year, but it would be nice to still have this, especially if you need to test something with a specific kernel. I can try to take a look at this a bit later, as I just returned from PTO. |
|
I'm pretty sure that none of the OVN developers is using vagrant, but if you still find it useful we need to update it and add CI so it doesn't break. |
|
Create a new pull request, #109, fixing the current Vagrant deployment. However, I could not find a way to add a GA CI due to the nested VM limitations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #102.
Currently the Vagrant deployment is broken, due to its use of the old Rocky Linux 8 base image that it uses. Considering this breakage, it seems unlikely that anybody is actually using the Vagrant deployment in their day-to-day use of ovn-fake-multinode. We could fix the Vagrant deployment by updating it to use a newer base image, but if nobody is using it there is no need to maintain it, and it will eventually break again in the future.
This PR deletes Vagrant and any mention of it from ovn-fake-multinode. No code is added, just deleted.