log-collector.sh: Fix collection of OF rules. - #205
Merged
Conversation
While dumping OF groups was limited to the last $limit containers on each node, that wasn't the case for OF rules. Impose the same limit to avoid wasting disk space for mostly similar outputs from all virtual nodes on large scale (500 node) runs. Also, reduce the $limit from 10 to 2 and pre-archive the dumped OF rules/groups text files for the same reason. Fixes: 3fa30c3 ("scripts: log-collector: Add ovs open-flows and group dump to log results") Signed-off-by: Dumitru Ceara <dceara@redhat.com>
dceara
commented
Oct 1, 2025
almusil
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While dumping OF groups was limited to the last $limit containers on each node, that wasn't the case for OF rules. Impose the same limit to avoid wasting disk space for mostly similar outputs from all virtual nodes on large scale (500 node) runs.
Also, reduce the $limit from 10 to 2 and pre-archive the dumped OF rules/groups text files for the same reason.
Fixes: 3fa30c3 ("scripts: log-collector: Add ovs open-flows and group dump to log results")