Default no-arg run to current directory and sync docs#53
Merged
Conversation
- Document no-arg run defaulting to the current directory - Add C-d (delete forward), C-x u (undo) keybindings to README - Add /commands slash alias to README - Drop shipped tree-sitter from AGENTS do-not-add list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewed the codebase against all documentation and corrected stale docs so they match the current implementation. Also includes the existing CLI change on this branch that makes a no-arg run default to the current directory.
Changes
CLI behavior (
src/cli.rs, already on this branch)cortexwith no path defaults to the current directory (.) instead of erroring. Verified bycli::tests::defaults_to_current_directory.README
C-das a delete-forward alias (keymap.rs:42).C-x uundo keybinding (keymap.rs:66) — it was bound but undocumented./commandsslash alias for/help(app.rs:357).AGENTS.md
tree-sitterfrom the "do not add before the roadmap asks" list. Tree-sitter highlighting shipped in v0.2 (issue [v0.2] Add tree-sitter syntax highlighting #20,src/highlighter.rs), so the entry was contradictory.Verification
cargo test— 144 passed, 0 failed.keymap.rs,commands.rs,app.rs, andpicker.rs.Follow-up (not in this PR)
docs/roadmap.mdlists undo/redo ([v0.3] Add undo and redo #27) under v0.3 as "Planned/open", but undo/redo is fully implemented, documented, and tested (and credited indocs/releases/v0.1.0.md). The roadmap ties status to issue closure by design, so the right fix is to close [v0.3] Add undo and redo #27 rather than edit roadmap status here. Flagging for product review.