-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Check for null pointer dereference (almost) everywhere #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for null pointer dereference (almost) everywhere #3120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of assertions will terminate the process, right? Is that what you want?
You can control the behavior with a macro. See the identical solution in case of libmodsecurity3. Here @gberkes introduced a new |
Yes, as it's an impossible path, unless the implementation is bogus |
Co-authored-by: Felipe Zipitría <[email protected]>
…ecurity into v2/mst/nullcheck2
Removed useless line
|
Looks good to me. I think the SonarCloud reports are false positives, all mentioned duplicate code had added years ago. Merging now - thanks, Marc. |
Added a design doc explaining the approach