Skip to content

Missing #include <time.h> #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

marcstern
Copy link

"struct tm" defined in time.h is used in re_variables.c.
time.h is not explicitely included, but is included via apr/apr-util.
In latest version of apr/apr-util, the inclusion is no more present, leading to a compilation failure.
This PR just adds the missing include.

@marcstern marcstern added the 2.x Related to ModSecurity version 2.x label Sep 25, 2024
@marcstern marcstern requested a review from airween September 25, 2024 12:04
Copy link

Copy link
Member

@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airween airween merged commit 02ca247 into owasp-modsecurity:v2/master Sep 25, 2024
41 checks passed
@marcstern marcstern deleted the v2/pr/time.h branch October 3, 2024 07:18
@marcstern marcstern restored the v2/pr/time.h branch October 22, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to ModSecurity version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants