ci: run build, test and lint on Crystal 1.21.0 only - #2463
Merged
Conversation
The build-crystal and tests matrices fanned out over 1.19.0, 1.20.0 and 1.21.0, and lint pinned 1.20.0. Six jobs per run for versions we no longer target, while the Dockerfile has already moved to crystal:1.21.0-alpine — so the images CI exercised did not match what ships. Collapse both matrices to 1.21.0 and move lint onto the same version. The matrix form is kept so extra versions can be re-added by editing a single list. AGENTS.md still documented 1.19.0 as the CI and Docker version; update it to match the tree. Note that shard.yml keeps `crystal: ~> 1.19` — the declared support range for consumers is unchanged, only what CI verifies narrows.
github-actions
Bot
added
🦺 github-action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI fanned
build-crystalandtestsout over Crystal 1.19.0, 1.20.0 and 1.21.0, and pinnedlintto 1.20.0 — six jobs per run for versions we no longer target. Meanwhile theDockerfilehas already moved tocrystallang/crystal:1.21.0-alpine, so the version CI exercised did not match what ships.build-crystalmatrix:[1.19.0, 1.20.0, 1.21.0]→[1.21.0]testsmatrix:[1.19.0, 1.20.0, 1.21.0]→[1.21.0]lint:1.20.0→1.21.0The matrix form is kept rather than inlined, so extra versions can be restored by editing a single list.
AGENTS.mdstill documented 1.19.0 as both the CI and Docker version; updated to match the tree.Out of scope
shard.ymlkeepscrystal: ~> 1.19. The declared support range for consumers is unchanged — only what CI verifies narrows.release-binaries.yml(1.20.0) andsnap/snapcraft.yaml(1.20.0) are release-build paths, not the build/test lanes this change targets, so they are left alone.