Skip to content

Support 404labfr/laravel-impersonate#904

Open
jose123v wants to merge 1 commit into
owen-it:masterfrom
jose123v:patch-1
Open

Support 404labfr/laravel-impersonate#904
jose123v wants to merge 1 commit into
owen-it:masterfrom
jose123v:patch-1

Conversation

@jose123v

Copy link
Copy Markdown

Closes #903

Using 404labfr/laravel-impersonate in owen-it/laravel-auditing saves the impersonated user instead of the impersonating user

@willpower232 willpower232 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically speaking, one has the ability to provide a custom user resolver in the configuration so this would be better as its own package which relies on owen-it/laravel-auditing and perhaps extends the base user resolver so it can still be used via similar code.

Also if this package starts supporting this impersonation library, it would probably end up supporting other libraries that change the user and that would require extra time and testing from the maintainers.

@cesarreyes3

Copy link
Copy Markdown

It may take some time until you realize this problem, it would be better to have it

@erikn69

erikn69 commented May 28, 2024

Copy link
Copy Markdown
Contributor

I have my doubts still,
it could help to get the real executor of the action in the case of that package, and if that package does not exist it should not affect the performance and it seems fine to me

@calebdw

calebdw commented Oct 17, 2024

Copy link
Copy Markdown

I use both packages and my audits table has both user and impersonator columns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants