V14 catchup #984
Closed
V14 catchup #984
+1,125
−1,010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing empty retrieved events and creating 2 models, would amount to 3 audit lines
+ added audit model in test
- Move part of the auditable responsible for determining auditable attributes to concern. - small cleanups Note: - removed a clause excluding on scalar values apart from certain cases. I do not believe we should exclude them by default, but rather handle the case where we are unable to use the value. "hidden" excludes are not desirable - Removed the protected excludes parameter. just not necessary.
- Move data collection to concern and perform moderate cleanup operations in the process - only resolve exclusions once per execution.
- Move data collection to concern and perform moderate cleanup operations in the process
Note, we need to rethink the transition. Currently it just places previous values onto the model, but intended functionality might be to replay audits so that correct state is reached if possible.
Add larastan analyse
…eployflow # Conflicts: # src/Contracts/Auditable.php # src/Resolvers/IpAddressResolver.php
Merge v13 fixes into v14 branch
# Conflicts: # .github/workflows/run-tests.yml # src/Audit.php # src/Auditable.php # src/Events/AuditCustom.php # tests/AuditingTestCase.php # tests/Functional/AuditingTest.php # tests/Models/Article.php # tests/Unit/AuditTest.php # tests/Unit/AuditableTest.php
# Conflicts: # src/Auditable.php # src/AuditableObserver.php # src/AuditingEventServiceProvider.php # src/AuditingServiceProvider.php # src/Resolvers/IpAddressResolver.php # src/Resolvers/UserAgentResolver.php # tests/Unit/AuditTest.php
willpower232
force-pushed
the
v14-catchup
branch
from
ecc6f3d to
0639540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to make a draft PR to run the automated tests whilst I try and figure out what is happening. Please ignore.