Skip to content
This repository was archived by the owner on Oct 30, 2018. It is now read-only.

use OCA.Search to customize results#57

Open
butonic wants to merge 4 commits intomasterfrom
fix_results_for_full_page
Open

use OCA.Search to customize results#57
butonic wants to merge 4 commits intomasterfrom
fix_results_for_full_page

Conversation

@butonic
Copy link
Copy Markdown
Contributor

@butonic butonic commented Feb 4, 2015

fixes #55 as the full text results were lacking the code to properly integrate with the full page results. code got lost somewhere ... cc @DeepDiver1975 @jnfrmarks

@karlitschek
Copy link
Copy Markdown

karlitschek commented Feb 4, 2015

makes sense 👍

@DeepDiver1975 DeepDiver1975 added this to the 8.0-current milestone Feb 4, 2015
@DeepDiver1975
Copy link
Copy Markdown
Contributor

DeepDiver1975 commented Feb 4, 2015

@butonic ouch - what happened to the unit tests?

@DeepDiver1975
Copy link
Copy Markdown
Contributor

DeepDiver1975 commented Feb 4, 2015

hmm - requires rebase ...

@butonic butonic force-pushed the fix_results_for_full_page branch from 21db916 to 8eeb587 Compare February 20, 2015 12:14
VicDeo
VicDeo reviewed Mar 30, 2015
View reviewed changes
search/luceneresult.php Outdated
Copy link
Copy Markdown
Contributor

@VicDeo VicDeo Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butonic a parent class has mime_type property here: https://github.com/owncloud/core/blob/master/lib/private/search/result/file.php#L62

@VicDeo VicDeo modified the milestones: 8.1-current, 8.0 Mar 30, 2015
VicDeo
VicDeo reviewed Mar 30, 2015
View reviewed changes
appinfo/app.php
Copy link
Copy Markdown
Contributor

@VicDeo VicDeo Mar 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butonic this file is missing in js folder

@butonic
Copy link
Copy Markdown
Contributor Author

butonic commented Apr 15, 2015

@VicDeo thx, added it

@VicDeo VicDeo force-pushed the fix_results_for_full_page branch from ee9ffc4 to 9e5cb4d Compare April 15, 2015 15:09
@VicDeo VicDeo force-pushed the fix_results_for_full_page branch from 9e5cb4d to 99cb0ac Compare April 27, 2015 16:43
@VicDeo VicDeo force-pushed the fix_results_for_full_page branch from 99cb0ac to fd670b8 Compare May 26, 2015 15:47
@butonic
Copy link
Copy Markdown
Contributor Author

butonic commented May 27, 2015

@VicDeo good to go?

@VicDeo
Copy link
Copy Markdown
Contributor

VicDeo commented May 27, 2015

@butonic TBH, I can't make search results to appear for master and this branch.
JSON response has the search results but they are not displayed.
Additionally for this PR console warn about missing etag is logged

@VicDeo
Copy link
Copy Markdown
Contributor

VicDeo commented May 28, 2015

@butonic ok, got it.

missing etag causes js error while quireing a preview and results are not rendered at all. Needs to be fixed in this PR

Additionally #searchresults has margin-top:-250px. when there are only results for 'other places' (e.g. lucene) these results are pushed too high to top (and become invisible). This one is tracked at owncloud/core#16878

@VicDeo VicDeo force-pushed the fix_results_for_full_page branch 2 times, most recently from f0449b3 to c4fb111 Compare May 30, 2015 07:32
@MorrisJobke MorrisJobke mentioned this pull request Aug 26, 2015
Closed
@MorrisJobke
Copy link
Copy Markdown
Contributor

MorrisJobke commented Oct 20, 2015

I don't think it will make it into 8.1 -> moving to 9.0

cc @karlitschek @cmonteroluque

@MorrisJobke MorrisJobke modified the milestones: 9.0-current, 8.1 Oct 20, 2015
@DeepDiver1975
Copy link
Copy Markdown
Contributor

DeepDiver1975 commented Oct 21, 2015

search lucene is a pure appstore app now - we need to push an updated version for 8.2

@DeepDiver1975
Copy link
Copy Markdown
Contributor

DeepDiver1975 commented Oct 21, 2015

in addition: taking care about comments would be great as well
https://apps.owncloud.com/content/show.php/Search+Lucene?content=168709

@MorrisJobke
Copy link
Copy Markdown
Contributor

MorrisJobke commented Mar 4, 2016

Not yet reviewed -> 9.1

@MorrisJobke MorrisJobke modified the milestones: 9.1-next, 9.0-current Mar 4, 2016
@PVince81 PVince81 modified the milestones: 9.1.1, 9.1 Jul 12, 2016
@PVince81
Copy link
Copy Markdown
Contributor

PVince81 commented Jul 12, 2016

moving to 9.1.1

@PVince81
Copy link
Copy Markdown
Contributor

PVince81 commented Aug 16, 2016

enhancement/new API -> 9.2 (let me know if you think otherwise)

@PVince81 PVince81 modified the milestones: 9.2, 9.1.1 Aug 16, 2016
@PVince81
Copy link
Copy Markdown
Contributor

PVince81 commented Apr 6, 2017

move to backlog or 10.0.1 ? (and find reviewers)

@PVince81
Copy link
Copy Markdown
Contributor

PVince81 commented Jun 29, 2017

backlog

@PVince81 PVince81 modified the milestones: backlog, 10.0 Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

5 - To review bug

Projects

None yet

Milestone

backlog

Development

Successfully merging this pull request may close these issues.

Search results only found in .pdf and .odt files

6 participants

@butonic @karlitschek @DeepDiver1975 @VicDeo @MorrisJobke @PVince81