Skip to content

[FEATURE REQUEST] Remove space link#4816

Merged
joragua merged 8 commits intomasterfrom
feature/remove_space_link
Apr 13, 2026
Merged

[FEATURE REQUEST] Remove space link#4816
joragua merged 8 commits intomasterfrom
feature/remove_space_link

Conversation

@joragua
Copy link
Copy Markdown
Contributor

@joragua joragua commented Apr 6, 2026 •
edited by jesmrec
Loading

Related Issues

App: #4757

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.8/Spaces%20-%20Remove%20link.md

Reports:

@joragua joragua self-assigned this Apr 6, 2026
@joragua joragua linked an issue Apr 6, 2026 that may be closed by this pull request
[FEATURE REQUEST] Remove space link #4757
Closed
11 tasks
@joragua joragua force-pushed the feature/remove_space_link branch 9 times, most recently from 6c531f6 to 1ce4fc6 Compare April 8, 2026 07:35
@joragua joragua marked this pull request as ready for review April 8, 2026 07:43
@joragua joragua requested a review from jesmrec April 8, 2026 07:43
jesmrec
jesmrec requested changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments @joragua

Comment thread ...udApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt Outdated
Comment thread ...udApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt
@joragua joragua force-pushed the feature/remove_space_link branch from ad69033 to e689625 Compare April 8, 2026 12:29
@joragua joragua requested a review from jesmrec April 8, 2026 12:42
jesmrec
jesmrec approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ! moving to QA

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Apr 13, 2026

QA approved on my side.

Created an issue in the oCIS side: owncloud/ocis#12211 because an incorrect error code when an inexistent link (previoulsy removed) is deleted again (404 instead of 400)

@joragua joragua force-pushed the feature/remove_space_link branch from 4538664 to 5cf67e8 Compare April 13, 2026 08:24
@joragua joragua merged commit 6ac162b into master Apr 13, 2026
13 checks passed
@joragua joragua deleted the feature/remove_space_link branch April 13, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Remove space link

3 participants

@joragua @jesmrec @ownclouders