Skip to content

Test delay in search bar on webUI #33493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Nov 13, 2018

Description

#32936 added delay in the search box for calling ajax which is not merged yet.
Add acceptance test for the search delay on top of #32936.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@dpakach dpakach self-assigned this Nov 13, 2018
@dpakach dpakach changed the title Test search type delay Test delay in search bar on webUI Nov 13, 2018
@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #33493 into master will decrease coverage by <.01%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33493      +/-   ##
============================================
- Coverage     64.07%   64.07%   -0.01%     
  Complexity    18315    18315              
============================================
  Files          1192     1192              
  Lines         69168    69171       +3     
  Branches       1277     1277              
============================================
+ Hits          44322    44323       +1     
- Misses        24474    24476       +2     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.9% <9.09%> (-0.01%) 0 <0> (ø)
#phpunit 65.37% <ø> (ø) 18315 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/search/js/search.js 34.7% <9.09%> (-0.02%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f6d22...facd47e. Read the comment docs.

@dpakach
Copy link
Contributor Author

dpakach commented Nov 19, 2018

This test is not very reliable.
While trying to measure the delay we get extra delay from the browser and test suite.
We can count ajax calls but we may encounter some other random ajax calls. So this is being closed.

@dpakach dpakach closed this Nov 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
@dpakach dpakach deleted the test-search-type-delay branch November 24, 2020 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay start of search to avoid searching for single letters
3 participants