Skip to content

chore(deps): bump @bower_components/blueimp-md5 from 1.0.1 to v2.19.0 in /build#39420

Merged
phil-davis merged 1 commit into
masterfrom
dependabot/npm_and_yarn/build/bower_components/blueimp-md5-v2.19.0
Jun 17, 2026
Merged

chore(deps): bump @bower_components/blueimp-md5 from 1.0.1 to v2.19.0 in /build#39420
phil-davis merged 1 commit into
masterfrom
dependabot/npm_and_yarn/build/bower_components/blueimp-md5-v2.19.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 25, 2021

Copy link
Copy Markdown
Contributor

Bumps @bower_components/blueimp-md5 from 1.0.1 to v2.19.0.

Commits

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@update-docs

update-docs Bot commented Oct 25, 2021

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis assigned phil-davis and unassigned phil-davis Oct 26, 2021
@phil-davis

Copy link
Copy Markdown
Contributor

Note: https://github.com/blueimp/JavaScript-MD5 repo is archived. v2.19.0 was released on 2021-09-25 and thus will be the last release.

Do we do this version bump now?

And then what next.

@JammingBen do we leave this for now, and investigate after 10.9.0? Or?

@JammingBen

Copy link
Copy Markdown
Contributor

do we leave this for now, and investigate after 10.9.0? Or?

I would say so, yes. Let's focus on simple and test/dev-related changes during the next weeks. 10.9 already contains a huge amount of big changes.

@phil-davis phil-davis marked this pull request as draft October 26, 2021 06:32
@phil-davis

Copy link
Copy Markdown
Contributor

I switched this to "draft" so that it is more clear that this is a "pending" bump for after 10.9.0

@mmattel

mmattel commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

@dependabot-bot rebase

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/build/bower_components/blueimp-md5-v2.19.0 branch from 948f291 to 118f757 Compare July 18, 2022 15:33
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mmattel mmattel requested a review from phil-davis July 18, 2022 18:05
@DeepDiver1975

Copy link
Copy Markdown
Member

@dependabot recreate

@dependabot dependabot Bot changed the title Bump @bower_components/blueimp-md5 from 1.0.1 to v2.19.0 in /build chore(deps): bump @bower_components/blueimp-md5 from 1.0.1 to v2.19.0 in /build Jun 8, 2026
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/build/bower_components/blueimp-md5-v2.19.0 branch from 118f757 to 88aa90f Compare June 8, 2026 12:56
@phil-davis phil-davis marked this pull request as ready for review June 17, 2026 14:45
@phil-davis

Copy link
Copy Markdown
Contributor

@dependabot rebase

Bumps [@bower_components/blueimp-md5](https://github.com/blueimp/JavaScript-MD5) from 1.0.1 to v2.19.0.
- [Commits](blueimp/JavaScript-MD5@b84e37f...458b662)

---
updated-dependencies:
- dependency-name: "@bower_components/blueimp-md5"
  dependency-version: 458b6624c39df94cd938db3303ef77aa1e7a6800
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/build/bower_components/blueimp-md5-v2.19.0 branch from 88aa90f to d4b09f6 Compare June 17, 2026 14:47

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should all still work. It is only in the /build folder, so does not impact the run-time.
Actually the source repo for this was archived some time ago. So v2.19.0 is the last version.

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated review by Claude Code review agent.

Overview

Dependabot PR bumping @bower_components/blueimp-md5 from 1.0.1 to v2.19.0 in /build, a major-version jump (1.x to 2.x). The change touches only build/package.json (dependency pin) and build/yarn.lock (resolved tarball + uid). +5/-4 across 2 files. This is low-risk automated content.

Code quality / style

  • Mechanical, well-scoped change generated by Dependabot. No hand-written code.
  • package.json and yarn.lock are kept consistent (both point at commit 458b662 for v2.19.0).
  • Note the version-string style mismatch: the old pin used #1.0.1 while the new pin uses #v2.19.0 (leading v). This simply follows the upstream tag naming and is fine for git-ref resolution.

Specific suggestions

  • Confirm blueimp-md5 is actually consumed in the bundled JS build and not dead weight. If it is used, verify the consuming code still works against the 2.x API (see risks).
  • After merge, regenerate/verify any vendored bundle so the new version is actually shipped, not just pinned.

Potential issues / risks

  • Major-version bump (1.x to 2.x) can carry breaking API changes. Upstream blueimp/JavaScript-MD5 migrated from a global md5() function toward UMD/module export conventions across the 2.x line. If owncloud/core calls it via a global md5(...), the call site may need adjustment; if it imports the module, behavior should be stable. The diff itself does not reveal how the library is invoked.
  • No accompanying source or test changes in this PR. There is no evidence that any usage was updated or that tests exercise the md5 code path against the new version. The risk is therefore not visible in the diff and rests on CI: ensure the build/JS test suite actually covers any code that depends on this library before merging. If md5 is unused, the bump is purely cosmetic and safe.
  • Bower-via-yarn git tarball dependencies are not integrity-pinned the way registry packages are (no checksum hash in the lock entry, only a resolved URL + uid). This is pre-existing and not introduced here.

Recommendation: Safe to merge once CI passes, provided the build/test pipeline covers code paths using blueimp-md5. If it does not, manually confirm the 2.x API matches the call sites before merging.

@phil-davis

phil-davis commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

PR #41633 confirms that this dependency is used. The JS Tests fail in that PR.

@phil-davis phil-davis merged commit 09b02f8 into master Jun 17, 2026
26 checks passed
@phil-davis phil-davis deleted the dependabot/npm_and_yarn/build/bower_components/blueimp-md5-v2.19.0 branch June 17, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants