Skip to content

fix: add missing space to mail footer signature delimiter #41617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phil-davis merged 2 commits into from
Jun 12, 2026
+11 −2
Merged

fix: add missing space to mail footer signature delimiter #41617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
299b019
fix: add missing space to mail footer signature delimiter
DeepDiver1975 Jun 11, 2026
45a3bc0
chore: rename changelog item to PR number and add PR link
DeepDiver1975 Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions changelog/unreleased/41617
View file
Open in desktop

@phil-davis phil-davis Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK that this changelog file is named 41364 but the PR is now 41617?

@DeepDiver1975 DeepDiver1975 Jun 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — I've renamed the file to 41617 to match the PR number and added the PR link alongside the issue link. Thanks!

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Bugfix: Add missing space to mail footer signature delimiter

We've fixed the signature delimiter in the email footer templates. The delimiter
on the first line was missing the trailing space required by the signature block
convention (RFC 3676), so mail clients were unable to recognize and collapse the
signature. The delimiter is now correctly written as "-- " (dash-dash-space).

https://github.com/owncloud/core/issues/41364
https://github.com/owncloud/core/pull/41617
2 changes: 1 addition & 1 deletion core/templates/html.mail.footer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
--<br>
-- <br>
<?php p($theme->getName()); ?> -
<?php p($theme->getSlogan()); ?>
<br><a href="<?php p($theme->getBaseUrl()); ?>"><?php p($theme->getBaseUrl());?></a>
Expand Down
2 changes: 1 addition & 1 deletion core/templates/plain.mail.footer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
--
--
<?php p($theme->getName() . ' - ' . $theme->getSlogan()); ?>
<?php
p("\n" . $theme->getBaseUrl());
Expand Down