chore(deps-dev): bump jasmine-core from 5.1.1 to 6.3.0 in /build#41621
Open
dependabot[bot] wants to merge 1 commit into
Open
chore(deps-dev): bump jasmine-core from 5.1.1 to 6.3.0 in /build#41621dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 5.1.1 to 6.3.0. - [Release notes](https://github.com/jasmine/jasmine/releases) - [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md) - [Commits](jasmine/jasmine@v5.1.1...v6.3.0) --- updated-dependencies: - dependency-name: jasmine-core dependency-version: 6.3.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
left a comment
DeepDiver1975
left a comment
Member
There was a problem hiding this comment.
Code Review
Overview
Dependabot bump of jasmine-core from 5.1.1 to 6.3.0 (major version) in the /build dev-dependency tree. Changes touch package.json and yarn.lock only — no production code affected.
Analysis
- Major version jump (5 → 6): Jasmine 6.x introduced breaking changes. The PR description links to release notes but does not surface what broke. Key breaking change from the Jasmine 6.0.0 release: the
jasminebinary is no longer included injasmine-core; a separatejasminepackage is required for CLI usage. If the project runs Jasmine via the CLI (rather than through karma), this will silently break the test runner. - karma-jasmine compatibility:
jasmine-sinon0.4.0 andkarma-jasminein the lock file should be checked for Jasmine 6 compatibility.jasmine-sinon0.4.0 was last released in 2016 and may not work with Jasmine 6's updated matchers API. - Diff is correct:
package.jsonpin updated to^6.3.0, lock file entry replaced with the new resolved hash and integrity. No extra files touched.
Concerns
- Test suite compatibility is unknown from the diff alone. Verify that CI passes with this change before merging — particularly the karma-based test run, since the
karma-jasmineadapter must support Jasmine 6. jasmine-sinon0.4.0 is very old and likely incompatible with Jasmine 6's updatedjasmine.matchersUtilAPI. If any tests usejasmine-sinonmatchers (e.g.,expect(spy).toHaveBeenCalledWith(...)), they may silently pass or fail unexpectedly.
Summary
Mechanically correct dependency bump. Safe to merge only after confirming the full JS test suite passes in CI — the major version bump carries real compatibility risk with the existing jasmine-sinon version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps jasmine-core from 5.1.1 to 6.3.0.
Release notes
Sourced from jasmine-core's releases.
... (truncated)
Commits
c2ead64Bump version to 6.3.005fd5cbBump version to 6.2.1f1a4ccfImprove spec namef41dc6aMerge branch 'fix/xdescribe-pending-reason' of github.com:Aryannaik-max/jasmine91a9e97test: ensure pendingReason survives reset in xdescribe testddde63afix: add pendingReason message for xdescribefc88950Run eslint and prettier after tests even if ignore-scripts=true6166a03Check in package-lock.json031ffc8Copy 7.0.0-pre.1 release notes from branchb05ea4bBump version to 6.2.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)