Skip to content

WIP: Blocklist domain validation #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enbrnz
Copy link
Contributor

@enbrnz enbrnz commented Nov 10, 2022

Description

Verifying that domains entered into blocklist settings input form are actual domains. If not, showing error message with problem domain.

Motivation and Context

If an invalid domain is entered the blocklist feature might not work as expected.
Fixes:

// FIXME: do validations here to make sure valid input is passed

Todo

Acceptance test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@enbrnz enbrnz changed the title Blocklist domain validation WIP: Blocklist domain validation Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant