Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/security-first-mdm] Add MDM/branding control over block_password_removal default value #1444

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

felix-schwarz
Copy link
Contributor

@felix-schwarz felix-schwarz commented Feb 5, 2025

Description

Adds a MDM/branding control over block_password_removal default value and reverts the default to the previous behavior.

New option:

connection.block-password-removal-default

If a server does not provide block_password_removal information as part of its capabilities, this option provides the fallback value controlling whether passwords can (value: false) or can not (value: true) be removed from an existing link even if capabilities otherwise indicate passwords need to be enforced for links.

Example configuration

To implement the behavior as requested in #1429, connection.block-password-removal-default needs to be set to false in the Branding.plist:

<key>connection.block-password-removal-default</key>
<false/>

Related Issue

#1429 -- SDK portion: owncloud/ios-sdk#139

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

- xcodeproj: add env-based debug toggle for connection.block-password-removal-default to simplify testing
@jesmrec
Copy link
Contributor

jesmrec commented Feb 6, 2025

This is the behaviour in the current PR:

  <key>connection.block-password-removal-default</key>
  <true/>

in this case, it's not posible to save a link if it does not have a password. Link passwords are really enforced

  <key>connection.block-password-removal-default</key>
  <false/>

in this case, link creation forces to add a password, but link edition does not. Password only enforced in creation.

If parameter connection.block-password-removal-default is not included in the Branding.plist file, the behaviour is the same as the one with <true/>

that's OK from my side.

@jesmrec jesmrec added the Approved by QA Approved by QA label Feb 6, 2025
@felix-schwarz felix-schwarz merged commit 048a2bb into master Feb 6, 2025
5 checks passed
@felix-schwarz felix-schwarz deleted the feature/security-first-mdm branch February 6, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants