[fix/remove-deleted-sidebar-items] Keep sidebar items in sync with their folders - #1588
Open
davidfuentes024 wants to merge 3 commits into
Open
davidfuentes024 wants to merge 3 commits into
davidfuentes024 wants to merge 3 commits into
Conversation
Track the location of each sidebar item and remove the item from the sidebar once its folder no longer exists. Fixes owncloud#1357
|
|
|
|
When a tracked folder disappears from its path, look it up by file ID. If it still exists, update the sidebar item's location instead of removing it.
davidfuentes024
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1357
Sidebar items are stored locally and were never updated when their folder changed.
AccountControllernow tracks each sidebar item's location withtrackItem(at:). When the folder disappears from that path, it is looked up by file ID:Tested on the simulator against oC 10.16.4: