Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only]Add support to stop and start service in ociswrapper #10776

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[full-ci][tests-only]Add support to stop and start service in ociswrapper #10776

wants to merge 1 commit into from
+427 −115

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Dec 17, 2024 •
edited
Loading

Description

This adds new feature on ocis wrapper to stop/ start sevices.

Related Issue

Motivation and Context

How Has This Been Tested?

  • start ocis > send api request to restart ocis service independently
    curl -XPOST 'http://localhost:5200/services/storage-users' -d'{"OCIS_LOG_LEVEL":"info"}'
  • stop service but ocis should be running without specific service
    curl -XDELETE 'http://localhost:5200/services/storage-users'
  • rollback ocis should stop all service and restart ocis with initial env
  • run tests locally
  • run on CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Dec 17, 2024
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch 3 times, most recently from 2125c45 to b3c2e20 Compare December 18, 2024 11:37
@amrita-shrestha
Copy link
Contributor Author

amrita-shrestha commented Dec 30, 2024 •
edited
Loading

waiting for #10808 to get merged

@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch 5 times, most recently from cc95565 to 5f509bd Compare January 7, 2025 16:37
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 8, 2025
Open
1 task
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch 3 times, most recently from 43f62bd to 27074ac Compare January 9, 2025 06:37
@amrita-shrestha amrita-shrestha marked this pull request as ready for review January 9, 2025 10:12
saw-jan
saw-jan requested changes Jan 10, 2025
View reviewed changes
tests/ociswrapper/wrapper/wrapper.go Outdated Show resolved Hide resolved
tests/ociswrapper/wrapper/handlers/handler.go Outdated Show resolved Hide resolved
tests/ociswrapper/wrapper/handlers/handler.go Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch from df7c67f to 296bdb6 Compare January 13, 2025 08:20
PrajwolAmatya
PrajwolAmatya reviewed Jan 13, 2025
View reviewed changes
tests/acceptance/bootstrap/OcisConfigContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/OcisConfigContext.php Outdated Show resolved Hide resolved
tests/ociswrapper/ocis/ocis.go Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch 2 times, most recently from e78d3cc to d7778d4 Compare January 13, 2025 11:47
saw-jan
saw-jan reviewed Feb 4, 2025
View reviewed changes
tests/ociswrapper/README.md Outdated Show resolved Hide resolved
saw-jan
saw-jan reviewed Feb 4, 2025
View reviewed changes
tests/ociswrapper/README.md Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch from 529ff35 to 43c5a2e Compare February 4, 2025 05:36
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch from 43c5a2e to ca9b9a4 Compare February 4, 2025 09:56
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch 5 times, most recently from ea5a0d3 to 448d37d Compare February 11, 2025 06:11
@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch from f9a74b2 to f9c698f Compare February 11, 2025 16:19
saw-jan
saw-jan approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, squash the commits
👍

@amrita-shrestha amrita-shrestha force-pushed the add-support-to-stop-and-start-service-in-ociswrapper branch from f9c698f to ed8346b Compare February 12, 2025 06:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@ishabaral ishabaral Awaiting requested review from ishabaral

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@nabim777 nabim777 Awaiting requested review from nabim777

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@phil-davis phil-davis Awaiting requested review from phil-davis

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amrita-shrestha @nirajacharya2 @saw-jan @S-Panta @PrajwolAmatya