Skip to content

Fix the expiration date response for links #11239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the expiration date response for links #11239

wants to merge 1 commit into from

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Apr 16, 2025 •
edited
Loading

Description

We fixed the inconsistency in the expiration date response for links

Related Issue

Motivation and Context

To fix two issues with the public link expirationDateTime

  1. The expirationDateTime in a response is always in UTC
  2. The client can't set the arbitrary expirationDateTime. The server changes the expirationDateTime to the end of the day considering TZ. The API should not restrict the client from setting any future expirationDateTime. All other staff like next 24-hour or end-of-day, it is UI sugar.

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@2403905 2403905 requested a review from kobergj April 30, 2025 14:34
@2403905 2403905 mentioned this pull request Apr 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Difference in the expiration date response for shares and links
2 participants
@2403905 @kobergj