Skip to content

[full-ci][tests-only] read concurrently from command running in pseudo-terminal #11289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented May 6, 2025

Description

concurrently read from command running in pseudo-terminal instead of reading at the end. This helps to preserve the output from the command.

Related Issue

Motivation and Context

Run CLI tests in MacOS

How Has This Been Tested?

  • test environment:
    • Linux
    • MacOS

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label May 6, 2025
@saw-jan saw-jan self-assigned this May 6, 2025
@saw-jan saw-jan mentioned this pull request May 6, 2025
11 tasks
@saw-jan saw-jan requested a review from deyankiteworks May 6, 2025 08:44
@saw-jan
Copy link
Member Author

saw-jan commented May 6, 2025

@deyankiteworks Could you help me check this PR on your Mac system?

  1. build the ociswrapper
  2. serve ocis using ociswrapper
  3. run the test
TEST_SERVER_URL='https://localhost:9200' \
BEHAT_FEATURE=tests/acceptance/features/cliCommands/resetUserPassword.feature:5 \
make test-acceptance-api

@deyankiteworks
Copy link
Member

deyankiteworks commented May 7, 2025

@deyankiteworks Could you help me check this PR on your Mac system?

  1. build the ociswrapper
  2. serve ocis using ociswrapper
  3. run the test
TEST_SERVER_URL='https://localhost:9200' \
BEHAT_FEATURE=tests/acceptance/features/cliCommands/resetUserPassword.feature:5 \
make test-acceptance-api

All local tests passed successfully on MacBook Pro, Nov 2023, M3 Pro, 18 GB RAM, macOS Sonoma 14.5.

Test result for Scenario: reset user password is shown below:

Screenshot 2025-05-07 at 15 21 02

@saw-jan saw-jan marked this pull request as ready for review May 7, 2025 14:25
@saw-jan
Copy link
Member Author

saw-jan commented May 7, 2025

All local tests passed successfully on MacBook Pro, Nov 2023, M3 Pro, 18 GB RAM, macOS Sonoma 14.5.

Thank you! @deyankiteworks ❤️

Co-authored-by: Prajwol Amatya <[email protected]>
@saw-jan saw-jan requested a review from PrajwolAmatya May 8, 2025 10:04
Copy link

sonarqubecloud bot commented May 8, 2025

@saw-jan saw-jan merged commit b06e6f1 into master May 8, 2025
4 checks passed
@saw-jan saw-jan deleted the test/fix-cmd-output-read branch May 8, 2025 12:04
ownclouders pushed a commit that referenced this pull request May 8, 2025
[full-ci][tests-only] read concurrently from command running in pseudo-terminal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] find alternative for Pty
3 participants