Skip to content

fix(graph): Don't use hardcoded groupOfNames in group creation #11776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(graph): Don't use hardcoded groupOfNames in group creation #11776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/fix-dont-use-hardcoded-groupOfNames-in-group-creation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Don't use hardcoded groupOfNames in group creation

When creating a group with different objectClass, it will always use groupOfNames instead of the one provided in the config.
The server now creates groups using the objectClass defined in the config.

https://github.com/owncloud/ocis/pull/11776
2 changes: 1 addition & 1 deletion services/graph/pkg/identity/ldap_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ func (i *LDAP) getGroupCreateLDAPDN(group libregraph.Group) string {
func (i *LDAP) groupToLDAPAttrValues(group libregraph.Group) (map[string][]string, error) {
attrs := map[string][]string{
i.groupAttributeMap.name: {group.GetDisplayName()},
"objectClass": {"groupOfNames", "top"},
"objectClass": {i.groupObjectClass, "top"},
// This is a crutch to allow groups without members for LDAP servers
// that apply strict Schema checking. The RFCs define "member/uniqueMember"
// as required attribute for groupOfNames/groupOfUniqueNames. So we
Expand Down