[tests-only][full-ci] Test: Run sharingNgLinkShare suite in K8s #11851
+73
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
anon-pradip
force-pushed
the
test/run-api-sharingNgLinkShare-suite-in-k8
branch
from
b29f989 to
1cdeb96
Compare
anon-pradip
force-pushed
the
test/run-api-sharingNgLinkShare-suite-in-k8
branch
2 times, most recently
from
571d51f to
70c89ea
Compare
anon-pradip
requested review from
individual-it,
kobergj and
phil-davis
as code owners
anon-pradip
requested review from
Ashim-Stha,
nirajacharya2 and
saw-jan
and removed request for
individual-it,
kobergj and
phil-davis
nirajacharya2
previously approved these changes
Dec 4, 2025
.drone.star
Outdated
| (waitForClamavService() if params["antivirusNeeded"] else []) + | ||
| (waitForEmailService() if params["emailNeeded"] else []) + | ||
| (waitK3sCluster() + deployOcis() + waitForOcis(ocis_url = ocis_url) + ociswrapper() + waitForOciswrapper() if run_on_k8s else ocisServer(storage, extra_server_environment = params["extraServerEnvironment"], with_wrapper = True, tika_enabled = params["tikaNeeded"], volumes = ([stepVolumeOcisStorage]))) + | ||
| (waitK3sCluster() + prepareOcisDeployment() + setupOcisConfigMaps() + deployOcis() + waitForOcis(ocis_url = ocis_url) + ociswrapper() + waitForOciswrapper() if run_on_k8s else ocisServer(storage, extra_server_environment = params["extraServerEnvironment"], with_wrapper = True, tika_enabled = params["tikaNeeded"], volumes = ([stepVolumeOcisStorage]))) + |
Contributor
There was a problem hiding this comment.
i don't think we need this for core api tests
Contributor
Author
There was a problem hiding this comment.
prepareOcisDeployment()- Builds ociswrapper (for@env-configtests) and enables basic auth (forcoreApiAuthtests)setupOcisConfigMaps()- Creates theocisnamespace (required before Helm deployment)
anon-pradip
force-pushed
the
test/run-api-sharingNgLinkShare-suite-in-k8
branch
3 times, most recently
from
251d117 to
8819392
Compare
anon-pradip
force-pushed
the
test/run-api-sharingNgLinkShare-suite-in-k8
branch
from
8819392 to
f89da82
Compare
|
Ashim-Stha
reviewed
Dec 5, 2025
| # Only create banned password ConfigMap for sharingNgLinkShare suite | ||
| if suite_name == "sharingNgLinkShare": | ||
| commands.append( | ||
| "kubectl create configmap -n ocis sharing-banned-passwords --from-file=banned-password-list.txt=%s/tests/config/drone/banned-password-list.txt" % dirs["base"], |
Contributor
There was a problem hiding this comment.
can we reuse existing configmap instead of creating a new sharing-banned-passwords?
sharing-banned-passwords-frontend
sharing-banned-passwords-sharing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes Made:
1. Modified
.drone.star- Split deployment into 3 steps:prepareOcisDeployment()(golang image):sedpatches tosharing/deployment.yaml:setupOcisConfigMaps()(k3d image with kubectl):tests/config/drone/banned-password-list.txt/etc/ocis/config/drone/banned-password-list.txtin sharing poddeployOcis()(golang image with Helm):2. Modified
tests/acceptance/bootstrap/OcisConfigContext.php:/etc/ocis/to relative paths instead of using absolute paths from test container because: Test usesconfig/drone/banned-password-list.txt→ K8s mounts to/etc/ocis/config/drone/banned-password-list.txtPassing CI: https://drone.owncloud.com/owncloud/ocis/49533/18
https://drone.owncloud.com/owncloud/ocis/49644/15/10
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: