Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
8224d42 to
b78e58c
Compare
| | permissions | all | | ||
| | stime | A_NUMBER | | ||
| | parent | | | ||
| | expiration | | |
There was a problem hiding this comment.
Now expiration date will be non-empty and relative so removed from assert since test subject is different than expiration date.
| parseDriveIDErrMsg = "could not parse driveID" | ||
|
|
||
| // default expiration for user/group shares created without one; space memberships are exempt | ||
| defaultShareExpirationDays = 30 |
There was a problem hiding this comment.
Should it be configurable?
| switch { | ||
| case invite.ExpirationDateTime != nil: | ||
| shareExpiration = utils.TimeToTS(*invite.ExpirationDateTime) | ||
| case !IsSpaceRoot(statResponse.GetInfo().GetId()): |
There was a problem hiding this comment.
I don't quite understand why you force every invite to have an expiration date. It's not correct. The task description sounds "When sharing files from the SAFE, all shares that are being created should have a suggested expiration date of 30 days. This value can be overridden by the creator, but the suggestion should be there all the same. "
This branch has not been deployed
4 participants
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: