build: drop the appstore target in favour of dist [4.2] (#635)

Backport of the master-side change for #622. The `Makefile` was byte-identical
between the two branches, so the resulting file is identical to master's.

The Makefile had two packaging targets. `dist` copies an explicit allowlist
(`all_src`); `appstore` rsynced the whole working tree and subtracted a
hand-maintained exclude list, writing to `build/richdocuments.tar.gz`, which
nothing reads. Only the denylist rotted. On this branch it lets through 13
tracked root entries that are not part of `all_src`:

  .eslintrc.json  .github         .php-cs-fixer.dist.php  .prettierrc.json
  .tsconfig.json  CHANGELOG.md    package.json            pnpm-lock.yaml
  pnpm-workspace.yaml             sonar-project.properties
  src             tsconfig.json   vite.config.ts

It also excluded `vendor/bin` and `vendor-bin` but never `vendor` or
`node_modules`, so after any build it packaged those too - which now includes
the karma tree, since #630 gave this branch a `test-js` target. Five of its
excludes name files that no longer exist (`.drone.star`, `.php_cs.dist`,
`.scrutinizer.yml`, `nbproject`, `screenshots`), and it called
`occ integrity:sign-app` unconditionally, so it failed without release
certificates present.

Nothing consumes it here: this branch has no `release.yml`, and `dist` is what
the release workflow publishes on the branches that do.

Removed with it, all dead once the target is gone: `project_dir`, `sign_dir`,
`appstore_dir`, `source_dir`, `package_name`, and a duplicate `occ=` assignment
that the later `occ=$(CURDIR)/../../occ` already overrode. Also dropped the two
references to `$(bower_deps)`, undefined here since #630.

No documentation change: this branch has no AGENTS.md.

The released artifact is unchanged, verified rather than argued: `make dist` in
`owncloudci/php:8.3` produces a tarball whose 167 entries are byte-identical to
the one built from the parent commit, and `make help` output is identical too.

Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Co-authored-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: oc-tmueller

Makefile

@@ -6,19 +6,13 @@ COMPOSER_BIN := $(shell command -v composer 2> /dev/null)
 PNPM ?= npx --yes pnpm@10
 
 app_name=richdocuments
-project_dir=$(CURDIR)/../$(app_name)
 doc_files=README.md
 src_dirs=appinfo assets css img js l10n lib templates
 src_files=admin.php settings.php
 all_src=$(src_dirs) $(src_files) $(doc_files)
 build_dir=$(CURDIR)/build
 dist_dir=$(build_dir)/dist
-sign_dir=$(build_dir)/sign
-appstore_dir=$(build_dir)/appstore
-source_dir=$(build_dir)/source
-package_name=$(app_name)
 cert_dir=$(HOME)/.owncloud/certificates
-occ=$(CURDIR)/../core/occ
 
 # composer
 composer_deps=vendor
@@ -27,37 +21,6 @@ acceptance_test_deps=vendor-bin/behat/vendor
 # node
 nodejs_deps=node_modules
 
-appstore:
-	mkdir -p $(sign_dir)
-	rsync -a \
-	--exclude=.git \
-	--exclude=.phan \
-	--exclude=build \
-	--exclude=.drone.star \
-	--exclude=.gitignore \
-	--exclude=.php_cs.cache \
-	--exclude=.php_cs.dist \
-	--exclude=.scrutinizer.yml \
-	--exclude=CONTRIBUTING.md \
-	--exclude=composer.json \
-	--exclude=composer.lock \
-	--exclude=l10n/.gitkeep \
-	--exclude=l10n/.tx \
-	--exclude=l10n/no-php \
-	--exclude=Makefile \
-	--exclude=nbproject \
-	--exclude=screenshots \
-	--exclude=phpcs.xml \
-	--exclude=phpstan.neon \
-	--exclude=phpunit*xml \
-	--exclude=tests \
-	--exclude=vendor/bin \
-	--exclude=vendor-bin \
-	$(project_dir) $(sign_dir)
-	@echo "Signing…"
-	$(occ) integrity:sign-app --privateKey=$(cert_dir)/$(app_name).key --certificate=$(cert_dir)/$(app_name).crt --path=$(sign_dir)/$(app_name)
-	tar -czf $(build_dir)/$(app_name).tar.gz -C $(sign_dir) $(app_name)
-
 # signing
 occ=$(CURDIR)/../../occ
 private_key=$(HOME)/.owncloud/certificates/$(app_name).key
@@ -97,7 +60,7 @@ $(nodejs_deps): package.json pnpm-lock.yaml
 #
 # dist
 #
-$(dist_dir)/$(app_name): $(composer_deps) $(bower_deps)
+$(dist_dir)/$(app_name): $(composer_deps)
 	rm -Rf $@; mkdir -p $@
 	cp -R $(all_src) $@
 	rm -Rf $@/l10n/.gitkeep
@@ -124,7 +87,7 @@ clean-build:
 
 .PHONY: clean-deps
 clean-deps:
-	rm -Rf $(nodejs_deps) $(bower_deps)
+	rm -Rf $(nodejs_deps)
 	rm -Rf vendor
 	rm -Rf vendor-bin/**/vendor vendor-bin/**/composer.lock