fix(web-pkg): hide sidebar editor action when the editor is already opened

[LukasHirt]

Description

When an editor is already opened and the user clicks on the Open in ... action, it pushes the same editor route into the history causing a bug where the user needs to click twice on the close button to actually close the editor. This change hides the editor action if an editor with matching route name is already opened which prevents this behaviour.

Related Issue

• refs Preview feature makes the app unresponsive #12108

Motivation and Context

No confusion with re-opening the active editor.

How Has This Been Tested?

• test environment: chrome & 🤖
• test case 1: added unit test
• test case 2: open an image in the preview app and open sidebar

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests
• Documentation
• Maintenance (e.g. dependency updates or tooling)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nabim777]

I have tested this bug-fix PR and found that it introduced the following changes:

• The preview button has been replaced with Open in Collabora.

Bug found in this PR

@LukasHirt When we open the image in Collabora and try to close it, the UI becomes unresponsive:

Screencast.from.01-17-2025.05.02.09.PM.webm

[saw-jan]

I have tested this bug-fix PR and found that it introduced the following changes:

• The preview button has been replaced with Open in Collabora.

Bug found in this PR

@LukasHirt When we open the image in Collabora and try to close it, the UI becomes unresponsive:

Screencast.from.01-17-2025.05.02.09.PM.webm

This should be fixed by #12112

[nabim777]

I have tested this bug-fix PR and found that it introduced the following changes:

• The preview button has been replaced with Open in Collabora.

Bug found in this PR

@LukasHirt When we open the image in Collabora and try to close it, the UI becomes unresponsive:
Screencast.from.01-17-2025.05.02.09.PM.webm

This should be fixed by #12112

Yes, it has been fixed by PR, and I have tested it.

[LukasHirt]

This will need some more work as the routeName is not always defined leading into wrong behaviour of hiding the action even outside of the editor. Since the regression has been fixed in #12112, I would suggest postponing this into next release.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[LukasHirt]

@nabim777 could you please retest this pr? I fallback to the app name when routeName is undefined which is the same approach as in other places of the code base. All should work as expected now.