-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web-pkg): hide sidebar editor action when the editor is already opened #12110
base: master
Are you sure you want to change the base?
Conversation
…pened When an editor is already opened and the user clicks on the Open in ... action, it pushes the same editor route into the history causing a bug where the user needs to click twice on the close button to actually close the editor. This change hides the editor action if an editor with matching route name is already opened which prevents this behaviour.
fe1a35b
to
dea4bbb
Compare
Quality Gate passedIssues Measures |
I have tested this bug-fix PR and found that it introduced the following changes:
Bug found in this PR@LukasHirt When we open the image in Collabora and try to close it, the UI becomes unresponsive: Screencast.from.01-17-2025.05.02.09.PM.webm |
This should be fixed by #12112 |
Yes, it has been fixed by PR, and I have tested it. |
This will need some more work as the |
Pull request was converted to draft
Description
When an editor is already opened and the user clicks on the Open in ... action, it pushes the same editor route into the history causing a bug where the user needs to click twice on the close button to actually close the editor. This change hides the editor action if an editor with matching route name is already opened which prevents this behaviour.
Related Issue
Motivation and Context
No confusion with re-opening the active editor.
How Has This Been Tested?
Types of changes