-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] accessibility test for basic functionalities of file view #12155
Open
koebel
wants to merge
15
commits into
master
Choose a base branch
from
basic-a11y-e2e-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+596
−0
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
248a6d9
moving scenario and step implementation from https://github.com/owncl…
koebel cbb641c
fix some steps, improve coding style, add check accessibility functio…
koebel e32de9e
removing unnecessary comments
koebel 8676f5c
add pnpm-lock.yaml
koebel e6ecc6e
remove step about logout
koebel 817204d
changing steps that do no assertion but just "reset" some settings to…
koebel 38b17c3
one more step that needs to be changed to Given
koebel 986cd7a
refactor analyzeAccessibilityConformity functions
koebel 614baf6
refactor accessibility rule tags
koebel 5e249c1
add getSelectors function
koebel cc787a8
replace selectors{} with getSelectors to avoid code duplication
koebel 3d5b06a
refactor analyze accessibility conformity function to take both singl…
koebel 314491d
make steps with known accessibility issues fail after these issues ha…
koebel 00df41f
fix lint errors
koebel 6140d0d
remove exclusion for tiles view as error couldn't be reproduced any l…
koebel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
Feature: Accessibility | ||
|
||
As a user with limited accessibility | ||
I want to be able to access all features of oCIS | ||
So that regardless of my abilities and circumstances, I can benefit from oCIS | ||
|
||
|
||
Scenario: check accessibility of files view | ||
Given "Admin" creates following users using API | ||
| id | | ||
| Alice | | ||
And "Alice" uploads the following local file into personal space using API | ||
| localFile | to | | ||
| filesForUpload/lorem.txt | lorem.txt | | ||
| filesForUpload/testavatar.jpg | testavatar.jpg | | ||
And "Alice" adds the following tags for the following resources using API | ||
| resource | tags | | ||
| lorem.txt | test-tag | | ||
| testavatar.jpg | test-tag | | ||
|
||
When "Alice" logs in | ||
Then "Alice" should not encounter any automatically detectable accessibility issues concerning the files section in default table view | ||
|
||
When "Alice" switches to the condensed table view | ||
Then "Alice" should not encounter any automatically detectable accessibility issues concerning the files section in condensed table view | ||
|
||
When "Alice" switches to the tiles-view | ||
Then "Alice" should not encounter any automatically detectable accessibility issues concerning the files section in tiles view | ||
Given "Alice" switches to the default table view | ||
|
||
When "Alice" selects the display options | ||
Then "Alice" should not encounter any automatically detectable accessibility issues concerning the display options menu | ||
Given "Alice" closes the display options menu | ||
|
||
When "Alice" opens the files context menu | ||
Then "Alice" should not encounter any automatically detectable accessibility issues concerning the files context menu | ||
Given "Alice" exits the files context menu | ||
|
||
When "Alice" selects new | ||
Then "Alice" should not encounter any automatically detectable accessibility issues concerning the new context menu | ||
|
||
When "Alice" selects the folder option within the new context menu | ||
Then "Alice" should not encounter any automatically detectable accessibility issues concerning the create new folder popup | ||
Given "Alice" cancels creating a new folder | ||
|
||
When "Alice" selects upload | ||
Then "Alice" should not encounter any automatically detectable accessibility issues concerning the upload context menu | ||
Given "Alice" exits the upload menu | ||
|
||
When "Alice" selects a file by selecting the corresponding checkbox | ||
Then "Alice" should not encounter any automatically detectable accessibility issues concerning the file actions buttons for that file | ||
Given "Alice" deselects the file |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be required when using
@axe-core/playwright