chore(web-pkg): [OCISDEV-477] move comment out of template #13275
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the comment in app wrapper outside of the template to avoid breaking the app layout in dev server.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors ESLint directive handling for the vuejs-accessibility/no-static-element-interactions rule in the AppWrapper component. The change moves the ESLint disable comment outside the template to avoid breaking the app, and adds a corresponding enable comment after the affected element.
- Changed from inline
eslint-disable-next-linetodisable/enableblock pattern - Moved ESLint comment outside the
<template>tag with explanatory note
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keep the comment in app wrapper outside of the template to avoid breaking the app layout in dev server.
Motivation and Context
Fixed layout.
How Has This Been Tested?
Types of changes