fix(linter): check globals entry for no-undef, only check es2026 globals for no-extend-native and no-constant-binary-expression

[Sysix]

These 3 rules are the only one which did not checked for "globals" and only lookedup the envs.
In the future PR I want to remove env from the lint context. It should be resolved into "globals" before.

Added one test case where we already tested the "globals" option

[Sysix]

• fix(linter): merge env from extended config files #20088
• refactor(linter): resolve globals from env on build #20100
• fix(linter): check globals entry for no-undef, only check es2026 globals for no-extend-native and no-constant-binary-expression #20089 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

Updates eslint rule implementations to treat globals configuration entries as “defined globals” when determining whether identifiers are global for no-undef, no-extend-native, and no-constant-binary-expression.

Changes:

• Introduces LintContext::is_global_defined to unify “global defined” checks across env globals and globals config.
• Replaces direct env_contains_var checks in the three rules with is_global_defined.
• Makes env_contains_var an internal helper.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
crates/oxc_linter/src/rules/eslint/no_undef.rs	Switches the rule’s global check to use ctx.is_global_defined.
crates/oxc_linter/src/rules/eslint/no_extend_native.rs	Switches the rule’s “is global object” check to use ctx.is_global_defined.
crates/oxc_linter/src/rules/eslint/no_constant_binary_expression.rs	Uses ctx.is_global_defined for new <Ident>() constructor global detection.
crates/oxc_linter/src/context/mod.rs	Adds is_global_defined and makes env_contains_var private.

Comments suppressed due to low confidence (1)

crates/oxc_linter/src/rules/eslint/no_undef.rs:82

• After switching to is_global_defined, the subsequent ctx.globals().is_enabled(name) check becomes redundant (since is_global_defined already considers non-"off" entries from globals). Keeping both checks makes the control flow harder to follow and suggests the two conditions differ when they currently do not in this context.

                if ctx.is_global_defined(name) {
                    continue;
                }

                if ctx.globals().is_enabled(name) {
                    continue;
                }

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks¹

---

_{Comparing 03-07-fix_linter_check_globals_entry_for_no-undef_no-extend-native_and_no-constant-binary-expression_ (7269cc0) with main (1735215)}

Footnotes

1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camc314]

👍

[camc314]

Merge activity

• Mar 9, 10:24 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 9, 10:24 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 9, 10:30 PM UTC: Merged by the Graphite merge queue.