feat(semantic): extend no_side_effects to include empty functions#20344
Draft
feat(semantic): extend no_side_effects to include empty functions#20344
no_side_effects to include empty functions#20344Conversation
Mark functions with empty bodies and simple parameters (no destructuring, no defaults, no rest) as side-effect-free in `Scoping::no_side_effects`. This allows Rolldown to use `scoping.no_side_effects()` as the single source of truth, eliminating its separate `SideEffectsFreeFunction` flag. Closes #20290 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scoping::no_side_effectsscoping.no_side_effects()as the single source of truth, eliminating its separateSymbolRefFlags::SideEffectsFreeFunctionflagDetails
"Empty and simple params" means:
BindingIdentifierwith no initializer (uses existingIsSimpleParameterListtrait)() => exprexcluded)Async and generator empty functions are included, consistent with esbuild and Rollup behavior.
Closes #20290
Test plan
cargo test -p oxc_minifierpasses (470 tests)cargo test -p oxc_semantic --testspasses🤖 Generated with Claude Code