perf(minifier): use atom_from_strs_array for template literal concat#20386
Draft
perf(minifier): use atom_from_strs_array for template literal concat#20386
Conversation
…nation Avoid intermediate heap String allocations by concatenating directly into the arena allocator. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes constant-folding for template literals in the minifier by avoiding intermediate String allocations when concatenating template quasi raw/cooked values, instead allocating the final result directly into the arena via atom_from_strs_array.
Changes:
- Replace
to_string()/into_string()+ concatenation withctx.ast.atom_from_strs_array([...])when merging template literal quasis intry_fold_add_op. - Do the same allocation optimization when inlining constant expressions into template literals in
inline_template_literal.
You can also share your feedback on Copilot code review. Take the survey.
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stringconcatenation withctx.ast.atom_from_strs_array()🤖 Generated with Claude Code