perf(linter): remove unnecessary clone of owned String in drain loop#20388
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an unnecessary String::clone() when creating a DisabledRule::Single after draining disable_start_map, leveraging the fact that drain() yields owned String keys that can be moved directly. This is a small performance/cleanup change in the linter’s disable-directive interval construction logic.
Changes:
- Remove a redundant
.clone()ofrule_namein the post-drain()loop when building loneeslint-disable rule_nameintervals.
You can also share your feedback on Copilot code review. Take the survey.
Merging this PR will not alter performance
Comparing Footnotes
|
Member
Author
Merge activity
|
…20388) ## Summary - After `drain()`, `rule_name` is already an owned `String` that can be moved directly - Remove the unnecessary `.clone()` call 🤖 Generated with [Claude Code](https://claude.com/claude-code)
43df6bf to
e4f7248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drain(),rule_nameis already an ownedStringthat can be moved directly.clone()call🤖 Generated with Claude Code