fix(linter): cap checker pool and workers to 4, add panic recovery per-file#1019
Open
armandthuillart wants to merge 1 commit into
Open
fix(linter): cap checker pool and workers to 4, add panic recovery per-file#1019armandthuillart wants to merge 1 commit into
armandthuillart wants to merge 1 commit into
Conversation
…r-file Cap checker pool and file-processing workers to 4 (min of configured value and runtime.GOMAXPROCS(0)). This prevents excessive goroutine count and reduces GC stack scanner pressure during concurrent TypeScript type checking, which was observed causing a stuck runtime.(*unwinder).next spinning at 100% CPU. Wrap per-file processing in the linter with a deferred panic recovery that logs the file name and rule name, then clears listener state so a panic in one file does not crash the entire lint run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch 0001 set the checker pool size to
runtime.GOMAXPROCS(0), creating excessive concurrent goroutines with deep TypeScript type-checking stacks. The Go GC stack walker can get stuck scanning these stacks, pinning a core at 100% CPU. This makes my laptop heat up significantly.It caps the checker pool to
min(4, runtime.GOMAXPROCS(0))and also the linter workers tomin(options.Workers, 4). Then it wraps per-file processing indefer/recoverso a rule panic doesn't abort the entire lint run.Related: oxc-project/oxc#23618