Update merlin for 5.2.0minus-6 #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam923
reviewed
Feb 17, 2025
| "col": 12 | ||
| }, | ||
| "type": "sig type t = int val x : int type s = Baz end", | ||
| "type": "sig type t = int val x : int @@ portable type s = Baz end", |
| val rev_map : ('a -> 'b) -> 'a list -> 'b list | ||
| val filter_map : ('a -> 'b option) -> 'a list -> 'b list | ||
| val concat_map : ('a -> 'b list) -> 'a list -> 'b list | ||
| val length : 'a list -> int @@ portable |
Contributor
There was a problem hiding this comment.
Is this good or bad? I would think we only want to print this with a higher verbosity?
Contributor
There was a problem hiding this comment.
I think this is bad. I think this will start popping up in a lot of places and be very confusing to users
Contributor
There was a problem hiding this comment.
I think this is fine actually. This is just a consequence of the stdlib being portable now
Contributor
dkalinichenko-js
approved these changes
Feb 18, 2025
Contributor
dkalinichenko-js
left a comment
dkalinichenko-js
left a comment
There was a problem hiding this comment.
The subsequent changes look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mostly straightforward. I think it would be good to review "Fix compilation problems" and "Account for new flags".