forked from ocaml-ppx/ocamlformat
-
Notifications
You must be signed in to change notification settings - Fork 15
Support for runtime metaprogramming #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
535f727 to
3acbc08
Compare
ccasin
reviewed
Oct 15, 2025
ccasin
reviewed
Oct 15, 2025
0f0176b to
98072f9
Compare
c165665 to
6ae29b6
Compare
ccasin
reviewed
Nov 14, 2025
ccasin
approved these changes
Nov 20, 2025
ccasin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more nitpicks below, but eagerly approving - thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for formatting runtime quotations and splices to ocamlformat.
The appropriate changes are added to the lexing, parsing, and formatting.
At the level of individual files, runtime metaprogramming can be enabled or disabled using a syntax directive:
#syntax quotations [on|off]. This requires that we add such directives as a construct that does not lead to an error in the lexer; in fact, it has to get propagated through the parser and the formatter. These lexer directives are represented using the newlexer_directivetype.