reduce number of jobs pushed through omq proxy thread. #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we queue cpu heavy work in lokinet to worker threads we make 1 job per function call. we call a lot of jobs so this coleases the jobs into 1 job that we push off at the end of the event loop cycle, reducing the number of jobs going across the omq proxy thread, in theory reducing cpu usage.
Contributor
Author
|
metric for measuring perf improvement: ratio of cumulative cpu usage across workers to cpu usage in the omq proxy thread. higher ratio is better. |
Contributor
Author
|
@jagerman please test this on testnet. |
Contributor
Author
|
it has a noticeable improvement on exit.loki. less context switches, lower system load average and higher throughput.
i'll test it on my service node this week to see what it improves. |
dr7ana
added a commit
to dr7ana/lokinet
that referenced
this pull request
Apr 28, 2023
Merging cherry-picks back to testnet branch: - oxen-io#2164 - oxen-io#2134
Contributor
Author
|
getting this into a point release would probably speed the network up a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we queue cpu heavy work in lokinet to worker threads we make 1 job per function call. we call a lot of jobs so this coleuses the jobs into 1 job that we push off at the end of the event loop cycle, reducing the number of jobs going across the omq proxy thread, in theory reducing cpu usage.
@jagerman
i am curious how much perf increase we get on snodes, so i'd like to have this tested on testnet