feat: optional driver label to distinguish same-backend variants - #23
Merged
Conversation
Add an optional `label` field to driver configs. When set, DriverFactory reports it as the driver name in results, so runs of the same backend with different configurations (e.g. oxia clusters of 3/6/12 nodes) appear as distinct series (oxia-3, oxia-6, oxia-12) instead of collapsing into one "oxia". Unset keeps the driver's own name, so existing configs are unchanged. Signed-off-by: Matteo Merli <mmerli@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
labelto driver configs (DriverConfig.label). When present,DriverFactoryuses it as the driver's reported name; otherwise the driver's own name is used (no behavior change for existing configs).Why
The comparison harness runs the same backend under different configurations — e.g. oxia clusters of 3, 6, and 12 nodes. Without a label they all report as
oxiaand collapse into one series in the aggregated report. Withlabel: oxia-3/oxia-6/oxia-12they stay distinct.Test
DriverConfigTestcovers parsing with and without a label;./gradlew testgreen.