chore: drop deprecated batchLinger from oxia driver configs - #28
Merged
Conversation
The oxia client's batchLinger option is deprecated, and OxiaDriver never applied it anyway (init() only wires up namespace and batchMaxCount), so the key was silently ignored. Remove it from every oxia driver config. No behavior change — the client already used its default linger. Signed-off-by: Matteo Merli <mmerli@apache.org>
100000 only inflates latency (~5s) without raising throughput — the ~20k/s ceiling is workload-bound (10M distinct keys), not in-flight-bound. Keep the example at 10000 so this PR is a pure batchLinger cleanup. Signed-off-by: Matteo Merli <mmerli@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the deprecated
batchLingerkey from every oxia driver config (the sixvalues-*.yaml, the fourcomparison/oxia*.yaml, andconf/driver-oxia.yaml).Why
batchLingeris deprecated in the oxia client, andOxiaDriver.init()never applied it in the first place — it only mapsnamespaceandbatchMaxCount(→maxRequestsPerBatch). So the key was dead config that misleadingly implied it was tuning the client. No behavior change: the client keeps using its default linger (5ms), exactly as before.