fix: bound jetcd callback thread pool in etcd driver - #32
Merged
Conversation
jetcd defaults to an unbounded cached thread pool for its async callbacks. Under a max-throughput run (thousands of in-flight requests) that grows to thousands of threads and OOMs the worker (native pthread EAGAIN). Pin it to a bounded fixed pool via Client.builder().executorService(), and shut it down in close(). executorService() is part of jetcd's stable core builder API, so it is safe against the shaded-jetcd ambiguity already noted in this file. Signed-off-by: Matteo Merli <mmerli@apache.org>
Signed-off-by: Matteo Merli <mmerli@apache.org> # Conflicts: # src/main/java/io/oxia/benchmark/driver/etcd/EtcdDriver.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Under a max-throughput run (thousands of in-flight requests) the etcd driver's worker OOMs. jetcd defaults to an unbounded cached thread pool for its async callbacks, which grows to ~9k threads under high concurrency and exhausts the worker's native memory (pthread
EAGAIN).Fix
Pin jetcd's callback executor to a bounded pool (
Executors.newFixedThreadPool(64)) viaClient.builder().executorService(...), and shut it down inclose().executorService()is part of jetcd's stable core builder API (unlikeconnectTimeout), so it's safe against the shaded-jetcd ambiguity already noted in this file.Verification
etcd completed the full YCSB throughput comparison on a real cluster with 0 failures and no OOM (previously OOMKilled mid-run).