Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refines the CI process by updating the justfile and GitHub workflows to streamline version checking, testing, and build steps.
- Updated the check-if-published target by introducing a package parameter.
- Integrated the embedded target build into the ci-test target, removing a separate build step from the CI workflow.
- Adjusted the GitHub token interpolation syntax in the Dependabot workflow.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| justfile | Modified check-if-published to include a package parameter and reorganized targets. |
| .github/workflows/dependabot.yml | Updated secret token formatting for consistency. |
| .github/workflows/ci.yml | Removed the separate embedded target build step, now integrated into ci-test. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:29
- [nitpick] Double-check that integrating the embedded target build into the 'ci-test' target fully replaces the functionality of the removed standalone build step without unintended side effects.
- - run: just ci-build-thumbv7em-none-eabi
|
|
||
| # Verify that the current version of the crate is not the same as the one published on crates.io | ||
| check-if-published: (assert-cmd 'jq') | ||
| check-if-published package=main_crate: (assert-cmd 'jq') |
There was a problem hiding this comment.
[nitpick] Ensure that the package parameter is consistently used throughout the target, especially with its later reference as '{{package}}', to maintain clarity and avoid confusion.
| uses: dependabot/fetch-metadata@v2 | ||
| with: | ||
| github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
| github-token: ${{secrets.GITHUB_TOKEN}} |
There was a problem hiding this comment.
[nitpick] Consider matching the typical formatting with spaces (i.e., '${{ secrets.GITHUB_TOKEN }}') to improve readability and maintain consistency across workflows.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 69.31% 69.31%
=======================================
Files 37 37
Lines 290 290
Branches 290 290
=======================================
Hits 201 201
Misses 51 51
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
nyurik
added a commit
that referenced
this pull request
Jun 6, 2025
## 🤖 New release * `automotive_diag`: 0.1.17 -> 0.1.18 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.1.18](v0.1.17...v0.1.18) - 2025-06-06 ### Fixed - fix justfile jq assertion ### Other - set release-plz CI ([#43](#43)) - readme link cleanup ([#42](#42)) - validate if published in CI ([#41](#41)) - sort lints - ci updates ([#40](#40)) - more ci updates ([#39](#39)) - More rework of CI and justfiles ([#38](#38)) - update dependabot - ci cleanup - justfile - justfile and ci cleanup - minor cleanup ([#37](#37)) - Refactor justfile and CI process ([#36](#36)) - a few minor just file adjustments </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.