Bump to Rust 2024 and rustc 1.88
#563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbott
reviewed
Aug 18, 2025
Comment on lines
+903
to
+908
| && let Some(rails) = &d.power.as_ref().unwrap().rails | ||
| { | ||
| if let Some(rails) = &d.power.as_ref().unwrap().rails { | ||
| if idx < rails.len() { | ||
| return Ok(rails[idx].clone()); | ||
| } else { | ||
| bail!("sensor count exceeds rails for {:?}", d); | ||
| } | ||
| if idx < rails.len() { | ||
| return Ok(rails[idx].clone()); | ||
| } else { | ||
| bail!("sensor count exceeds rails for {:?}", d); |
Contributor
There was a problem hiding this comment.
This diff looks very strange without context, care to spot check it?
Contributor
Author
There was a problem hiding this comment.
After checking, I think this is correct – it hoisted the if let Some(..) into a let chain in the outer conditional.
labbott
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
letchainsChanges were mostly done mechanically by
cargo clippy --fix, with a few hand-edits to fixgenbecoming reserved.