Let humility map work with programmer attached
#564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
force-pushed
the
mkeeter/humility-map
branch
from
9fa56bd to
17d26ff
Compare
Contributor
Author
|
CI fix: this adds |
labbott
approved these changes
Sep 2, 2025
Comment on lines
+101
to
+108
| CommandKind::Unattached { archive } => { | ||
| if let Some(h) = &context.archive | ||
| && context.core.is_none() | ||
| && *archive == Archive::Required | ||
| { | ||
| // we'll try both `attach_dump` and `attach_archive` for maximum | ||
| // flexibility; they're allowed to fail, in which case the | ||
| // `core` will be left as `None`. |
Contributor
There was a problem hiding this comment.
it feels a little strange to have have Archive::Required but it is still allowed to fail.
Contributor
Author
There was a problem hiding this comment.
Yeah, the semantics here are awkward. Archive::Required means you must pass in a Humility archive, but does not mean that that archive must be attachable as an in-memory core. In practice, I don't think there are any cases where it can't be attached; I'll add some debug logging to warn if that happens.
mkeeter
force-pushed
the
mkeeter/humility-map
branch
from
c71f8b2 to
2c67016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
humility mapwould work in two configurations:This is annoying, so I'm fixing it: a command can now specify
CommandKind::Unattached { archive: Archive::Required }to run with anArchiveCore.