Ignore archive with rebootleby #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bootleby archive looks kind of like a hubris archive but it can't actually be fully loaded with `-a`. This isn't a problem because rebootleby takes the archive separately but it can create confusion if you do attempt to pass it in. Just ignore the archive.
Contributor
Author
|
This PR sponsored by a brief 15 minute freakout that we had broken |
mkeeter
approved these changes
Oct 8, 2025
Contributor
mkeeter
left a comment
mkeeter
left a comment
There was a problem hiding this comment.
Approved for expedience, although an Archive::Forbidden that prints an error message could be a good useful addition...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bootleby archive looks kind of like a hubris archive but it can't actually be fully loaded with
-a. This isn't a problem because rebootleby takes the archive separately but it can create confusion if you do attempt to pass it in. Just ignore the archive.