Fix udprpc buffer copy#654
Merged
Merged
Conversation
mkeeter
force-pushed
the
mkeeter/fix-udprpc-buf-len
branch
from
May 5, 2026 16:30
eda8170 to
bd51558
Compare
mkeeter
force-pushed
the
mkeeter/fix-udprpc-buf-len
branch
from
May 5, 2026 21:08
bd51558 to
aff05e1
Compare
labbott
approved these changes
May 6, 2026
labbott
left a comment
labbott
left a comment
Contributor
There was a problem hiding this comment.
I thought I hit approve yesterday but maybe it got lost?
I think I convinced myself this is correct so LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #608, we changed the
udprpcbackend to truncate the returned buffer based on the actual number of bytes received. However, we still tried to copynreplybytes out of that buffer. This fails if the reply type has been serialized (e.g. with Hubpack) and is shorter than the maximalnreply.This PR changes the implementation to extract and copy the (variable-size) reply portion of the buffer, instead of a fixed
nbytes-sized chunk.Fixes #653, tested on
niles