[10/n] [sled-agent/wicketd] a few error handling fixes#10854
Merged
sunshowers merged 3 commits intoJul 17, 2026
Merged
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Jul 17, 2026
| // | ||
| // The Progenitor alternate formatter is slightly better than | ||
| // InlineErrorChain here, because the latter would double-print the | ||
| // first cause due to the way Progenitor's error display works. |
Contributor
There was a problem hiding this comment.
Is this a (minor, common, annoying to fix because if we do consumers that don't print the chain will start getting less information) bug in progenitor's error display impl?
Contributor
Author
There was a problem hiding this comment.
Yeah, I think it is. InlineErrorChain should always do the correct thing.
sunshowers
changed the base branch from
sunshowers/spr/main.10n-sled-agentwicketd-a-few-error-handling-fixes
to
main
July 17, 2026 18:42
Created using spr 1.3.6-beta.1
sunshowers
enabled auto-merge (squash)
July 17, 2026 18:43
sunshowers
deleted the
sunshowers/spr/10n-sled-agentwicketd-a-few-error-handling-fixes
branch
July 17, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFD 710 gives us the opportunity to have a fresh look at some of the error handling. Make a few fixes that all flow into the commissioning API:
ba_lockstep_clientnow returns a 503 if we don't yet know the IP.Depends on: