[draft] [14/n] [wicketd] add the commission API, client, and OpenAPI document#10857
Draft
Conversation
Created using spr 1.3.6-beta.1
JustinAzoff
reviewed
Jul 17, 2026
Comment on lines
+76
to
+83
| InProgress { | ||
| /// The 1-based index of the currently-running top-level step. | ||
| step: u32, | ||
| /// The total number of top-level steps in the update. | ||
| total_steps: u32, | ||
| /// A human-readable description of the innermost running step. | ||
| description: String, | ||
| }, |
Contributor
There was a problem hiding this comment.
This is not a dealbreaker and I can work with this structure, but would appreciate slightly more information:
- the percentage completion of this step, if known. this applies mostly to downloading installinator, since it takes 25 minutes and the bulk of the update time.
- the list of descriptions, not just the innermost. like
["Running installinator", "Writing host, control plane, and measurement artifacts", "Validating checksum of host phase 2 in slot B"]
Contributor
Author
There was a problem hiding this comment.
Ah the problem is that it isn't just a flat list, it's actually a tree of statuses. We can definitely represent that in the output, but the full event log is as rich as it is because of that.
Contributor
There was a problem hiding this comment.
ah that's ok.. the percentage is the much more important thing.. just knowing that it is not stuck.
sunshowers
changed the title
sunshowers
changed the title
sunshowers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
TODO: